Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve how-to and ref info for apps #1868

Merged
merged 3 commits into from
Aug 10, 2023
Merged

docs: improve how-to and ref info for apps #1868

merged 3 commits into from
Aug 10, 2023

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Aug 10, 2023 •
edited
Loading

Replaces #1785 . That PR had lots of reviews and discussions but got corrupted.

Closes #1732

  • This PR corrects and clarifies info about integrating KLT into a Kubernetes workflow/cluster
  • Also adds remarks about annotations vs labels
  • This PR includes an architecture piece about KeptnApp and KeptnWorkload but we decided that this belongs in the section about the Scheduler (docs: keptn Scheduler architecture documentation #1777). This file is temporarily still here until Yash can grab it.
  • Information about the annotations for pre/post-deployment evaluations/tasks really is not part of Integrating the app. We probably need a separate page about using the release lifecycle management feature and move that information over there. For now, let's leave the info here and I filed create page about implementing the release lifecycle management feature #1784 .

@StackScribe StackScribe added the documentation Improvements or additions to documentation label Aug 10, 2023
@StackScribe StackScribe added this to the 0.9 milestone Aug 10, 2023
@StackScribe StackScribe requested review from a team as code owners August 10, 2023 08:04
@StackScribe StackScribe self-assigned this Aug 10, 2023
@netlify
Copy link

netlify bot commented Aug 10, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 94f38c5
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64d49fca1fb64e00087d3396
😎 Deploy Preview https://deploy-preview-1868--keptn-lifecycle-toolkit.netlify.app/docs/implementing/tasks
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@StackScribe StackScribe mentioned this pull request Aug 10, 2023
Closed
@StackScribe
xref
8a631a3 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
xref to basic-annotations
94f38c5 
Signed-off-by: Meg McRoberts <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

odubajDT
odubajDT approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

@StackScribe StackScribe merged commit 7139ffd into keptn:main Aug 10, 2023
@StackScribe StackScribe deleted the 0809-keptnapp branch August 10, 2023 12:45
@keptn-bot keptn-bot mentioned this pull request Aug 10, 2023
Merged
mowies added a commit that referenced this pull request Aug 22, 2023
@mowies
revert back to previous sections that were done in #1868
3db61e9 
Signed-off-by: Moritz Wiesinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees

@StackScribe StackScribe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.8.3
Development

Successfully merging this pull request may close these issues.

improve KeptnApp and integrate docs
3 participants
@StackScribe @bacherfl @odubajDT